Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration option to disable rotating spinner #5

Closed
olivierlacan opened this issue Aug 21, 2013 · 4 comments
Closed

Add configuration option to disable rotating spinner #5

olivierlacan opened this issue Aug 21, 2013 · 4 comments

Comments

@olivierlacan
Copy link

First, thank you for this project. I discovered the page:fetch and page:load events recently and was thinking about building something similar (but not nearly as unobtrusive). This project appeared at the perfect time. 😺

It seems redundant to me to have a rotating spinner and and a loading indicator bar. If the goal is to pretend to give a real progress bar, go for it. Don't mix in a indeterminate loader at the same time.

At least it should be an option. While it's easy to integrate a thin horizontal bar with basically no design changes, the rotating spinner overlays with existing navigation elements on the app I'm using it on. And it's likely to cause similar issues with other people as well.

image

@rstacruz
Copy link
Owner

Hey! You can just remove the entire section from the CSS file.

(On a side note, I've found that it's best to reposition it -- try placing it next to your logo!)

@rahulcs
Copy link
Contributor

rahulcs commented Aug 21, 2013

@rstacruz I have added a configuration option to disable the spinner. Would you be willing to accept a PR?

@rstacruz
Copy link
Owner

How's it like?

@rahulcs
Copy link
Contributor

rahulcs commented Aug 21, 2013

Here's my PR: #9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants