-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration option to disable rotating spinner #5
Comments
Hey! You can just remove the entire section from the CSS file. (On a side note, I've found that it's best to reposition it -- try placing it next to your logo!) |
@rstacruz I have added a configuration option to disable the spinner. Would you be willing to accept a PR? |
How's it like? |
Here's my PR: #9 |
rstacruz
added a commit
that referenced
this issue
Aug 21, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
First, thank you for this project. I discovered the
page:fetch
andpage:load
events recently and was thinking about building something similar (but not nearly as unobtrusive). This project appeared at the perfect time. 😺It seems redundant to me to have a rotating spinner and and a loading indicator bar. If the goal is to pretend to give a real progress bar, go for it. Don't mix in a indeterminate loader at the same time.
At least it should be an option. While it's easy to integrate a thin horizontal bar with basically no design changes, the rotating spinner overlays with existing navigation elements on the app I'm using it on. And it's likely to cause similar issues with other people as well.
The text was updated successfully, but these errors were encountered: