Use correct 'main' file in package.json #83
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `package.json` file doesn't contain the correct 'main' field which means that you can't just `require('nprogress')`. This PR will resolve this.
|
+1 |
1 similar comment
|
+1 |
|
Does anyone know Rico personally and can confirm that he's alright? He hasn't been seen in over a month. |
|
He's still active on GitHub, look at his profile. I merged this PR to my fork and pushed to npm as "nprogress-npm": https://www.npmjs.org/package/nprogress-npm |
|
@frankie-loves-jesus I can't, it was closed by the owner @rstacruz... |
|
Pretty sure you can reopen it unless it has been locked |
|
@callumacrae I think it has, the button is not there... |
|
You can't talk in locked conversations. Weird, they must have changed it so that reporters can't reopen them. |
|
This has been fixed in 0.1.5. Thanks folks! You should now be able to use nprogress with browserify and webpack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
package.jsonfile doesn't contain the correct 'main' field which means that you can't justrequire('nprogress'). This PR will resolve this.