-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[React 18] Update to be compatible. #80
Conversation
Thanks, I was really having trouble getting React 18 to work myself. Is this ready for review? |
@rstacruz At least the implementation of this so far works for my production build. I couldn't get the testing to work locally- and I believe the testing would also need an update. But it's more or less ready for review. |
Just updated in latest commit. |
Thanks for this! I'll try to look into this when I have time -- one thing we will need to update is all documentation. |
Interesting - looks like the way this works is it creates a hard dependency on React, and prevents implementing custom adapters for non-React frameworks. I think that might be alright - I'm not sure if anyone uses Remount in that way (would love to hear if anyone knows!) and we may have to remove that feature altogether. (...either that, or implement it in a way that doesn't change the signature of custom adapters) |
There's also a few tests that might need to be updated - looks like the *.html tests still reference react@16 🤔 |
Also it looks like the shadow DOM workarounds provided in react-shadow-dom-retarget-events will no longer be needed :) |
Thanks for your contribution! I continued it on a bit over at #81 - hopefully it should be a bit more comprehensive :) |
Closing since this has been moved to #81 |
React 18 support is now out in remount@1.0.0 - https://github.com/rstacruz/remount/releases/tag/v1.0.0 |
Updating
ReactDOM.render
to the newcreateRoot
function specified in the React 18 upgrade.This PR only updates
custom_elements.js
which is what I'm using in my Rails application. Work still needs to be done formutation_obersver.js