Moved function definition #1136
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Wow, this is incredibly bad if the order matters like this. Do you have a reprex that triggers on this particular issue? I don't see anything in rstudio/shinytest2#330. |
|
I tried to create a reprex but it looks like this issue happens only in a package structure. I created a repository where the issue is replicable: https://github.com/MichalLauer/DTReprex. To replicate, you need to:
It's strange that you really don't need to pass any data to it - the error happens with any DT settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
the only purpose of this PR is to change the order of function definition. Currently,
processWidget()is used in functionwidgetFunc(), but only after it's definition. This makes the package https://github.com/rstudio/shinytest2 fail because it does not allow global variables.I am aware that this issue is more related to
{shinytest2}rather than to{DT}, but the issue there is stale (rstudio/shinytest2#330). As this change does not affect any functionality, I thought it could be fixed right here.If I should update also the package version/NEWS or something similar, please, feel free to let me know.
If you do not like this change, I will understand.
Thanks for this package and your hard work :)