Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lazyRender parameter #1158

Merged
merged 12 commits into from
Nov 25, 2024
Merged

Add lazyRender parameter #1158

merged 12 commits into from
Nov 25, 2024

Conversation

Mosk915
Copy link
Contributor

@Mosk915 Mosk915 commented Nov 25, 2024

This resolves #1156. It adds the option to have the table render immediately rather than waiting for it to become visible.

yihui
yihui reviewed Nov 25, 2024
View reviewed changes
Copy link
Member

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's write lazyRender to params only if it's FALSE, to make the gigantic JSON output a few bytes smaller :) Would that be okay to you?

BTW, please roxygenize the docs via Rd2roxygen::rab(build = FALSE). Thanks!

NEWS.md Outdated Show resolved Hide resolved
R/datatables.R Outdated Show resolved Hide resolved
R/datatables.R Outdated Show resolved Hide resolved
inst/htmlwidgets/datatables.js Outdated Show resolved Hide resolved
Mosk915 and others added 6 commits November 25, 2024 17:43
@Mosk915 @yihui
Update NEWS.md
ecad392 
Co-authored-by: Yihui Xie <xie@yihui.name>
@Mosk915 @yihui
Update R/datatables.R
ca352c6 
Co-authored-by: Yihui Xie <xie@yihui.name>
@Mosk915 @yihui
Update R/datatables.R
f907b6f 
Co-authored-by: Yihui Xie <xie@yihui.name>
@Mosk915 @yihui
Update inst/htmlwidgets/datatables.js
b54927b 
Co-authored-by: Yihui Xie <xie@yihui.name>
@Mosk915
Only write lazyRender to params if FALSE
3d00b4c
@Mosk915
roxygenize docs
6d21162
@Mosk915
Copy link
Contributor Author

Mosk915 commented Nov 25, 2024

@yihui Makes sense. I accepted the changes you made and made the change to only write lazyRender to params if it's FALSE. Hopefully I did it as you intended. I also reoxygenized the docs.

yihui
yihui approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks again!

R/datatables.R Outdated Show resolved Hide resolved
@yihui yihui merged commit def0cae into rstudio:main Nov 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yihui yihui yihui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Render table before it is displayed
2 participants
@Mosk915 @yihui