add editable parameter #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihui
requested changes
Jan 19, 2018
inst/htmlwidgets/datatables.js
Outdated
| @@ -668,28 +668,30 @@ HTMLWidgets.widget({ | |||
| // run the callback function on the table instance | |||
| if (typeof data.callback === 'function') data.callback(table); | |||
|
|
|||
| if (data.editable) { | |||
There was a problem hiding this comment.
This PR looks good to me, but I hope to avoid the changes from indentation. You don't need the curly braces since it is a single expression, e.g.
if (data.editable) table.on('dblclick.dt', 'tbody td', function() {
...
yihui
approved these changes
Jan 19, 2018
|
Awesome thanks! |
|
Would it be possible to make that edition is not only usable for visual purposes but that actual values are also changed? reactiveValues variables visualized through DT can be edited on the table but edits are not saved to the variables. This was possible with previous feature/editor branch, but it seems this brach is not active anymore. |
|
@danielcanueto Did you read the examples in #480? |
|
Sorry, I hadn't seen this pull. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I run roxygen all the rd files get rewritten so I didn't update docs
Feel free to disregard this PR if you have a different implementation.
Fixes #483