feat(bslib_page): Set global theme temporarily during render #815
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft proposal that fixes #813. In essence, it attaches the page-level theme to the
bslib_page
classed object in the"bs_theme"
attribute. I then modifiedprint.bslib_page()
andas.tags.bslib_page()
(not sure if that's necessary) to temporarily set the global theme using this attribute.In #813 the slider in the following example is only partly styled, with this fix
bs_dependency_defer()
correctly uses the currenttheme
.