fix(themer-demo): Fix is_legacy_version
#918
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #916 by correctly setting the
is_legacy_version
variable when the theme is version 3 or 4.In short,
theme_version(bs_global_get())
can returnNULL
, in which case we can fall back toversion_default()
.Actually, after fixing the above issue I realized that the themer demo didn't work correctly in this case anyway. Instead of falling back to the default version, we now fall back to the default theme, much earlier in the app.