-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct docs for R6 classes #123
Conversation
Thanks for pointing this out to us @olivroy. I understand this doesn't look as good as it possibly could, but it sounds like a fix will be applied upstream. As long as our documentation is still readable and functional, I'd prefer to just wait for the upstream fix at which point this will resolve itself. |
@gadenbuie it's probably going to be a while until a fix gets into roxygen2, so I think you should merge this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only need to redocument and this would be ok to go |
See https://rstudio.github.io/chromote/reference/Chromote.html
There is a bug on the top of the page.
This correction is done to circumvent r-lib/roxygen2#1504
Edit: changes to the R files could be reverted once the issue is fixed.