Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move split_code_headers() to gradethis #313

Merged
merged 3 commits into from
May 25, 2022
Merged

Move split_code_headers() to gradethis #313

merged 3 commits into from
May 25, 2022

Conversation

gadenbuie
Copy link
Member

Previously, split_code_headers() was a staticexport from learnr, but after rstudio/learnr#698 it will no longer be used by learnr, so it's being moved here.

Previously, `split_code_headers()` was a staticexport from learnr, but after rstudio/learnr#698 it will no longer be used by learnr, so it's being moved here.
@gadenbuie gadenbuie changed the title Move split_code_headers() to gradethis Move split_code_headers() to gradethis May 25, 2022
@gadenbuie gadenbuie requested a review from rossellhayes May 25, 2022 20:28
Copy link
Contributor

@rossellhayes rossellhayes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just to confirm, we're not planning to export this function, just use it as an internal function within gradethis?

@gadenbuie gadenbuie merged commit ef28fd2 into main May 25, 2022
@gadenbuie gadenbuie deleted the split-code-headers branch May 25, 2022 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants