-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly register knit_print S3 methods #108
Conversation
455c6f2
to
3f994f0
Compare
Will Shiny 1.2.0 be able to work with both older and newer htmltools? Or do we really need to do a completely synchronized pair of releases? |
Here are the combinations:
So there is a problem with the upgrade path. We can't release htmltools first because it breaks shiny. If we released Shiny first (I could remove the htmltools version bump), then Maybe the best solution is to continue to export the |
3f994f0
to
c4e1d83
Compare
c4e1d83
to
42712f7
Compare
I've changed this PR so that the only change is the the explicit registration of S3 methods; the |
This PR un-exports the
knit_print
methods and registers them as S3 methods when both knitr and htmltools are loaded.With R >=3.5.0, htmltools must be attached in order for the methods to work. There's an exception when shiny is attached: because shiny imports and re-exports these methods, they will also work if shiny is attached.
One consequence is that, because htmltools no longer exports these functions, Shiny can't import them. So Shiny will need to be updated to stop doing that.
Note that the CRAN version of Shiny (1.1.0) cannot be installed with this version of htmltools -- Shiny will fail to build because it can't import the
knit_print
methods from htmltools. If this version of htmltools is installed with an existing Shiny 1.1.0 installation, I believe that Shiny will no longer be able to be loaded.