Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iconCreateFunction does not work when used in leafletProxy #420

Closed
gegrimm opened this issue Apr 19, 2017 · 5 comments · Fixed by #696
Closed

iconCreateFunction does not work when used in leafletProxy #420

gegrimm opened this issue Apr 19, 2017 · 5 comments · Fixed by #696

Comments

@gegrimm
Copy link

gegrimm commented Apr 19, 2017

see: http://stackoverflow.com/questions/43483696/iconcreatefunction-does-not-work-when-adding-markers-with-leafletproxy

basically when using markerClusterOptions(), if you try to pass your own JS to alter appearance of cluster, this only works when rendering leaflet() but breaks when later adding markers with leafletProxy()

@NilsOle
Copy link

NilsOle commented Dec 29, 2017

@nicocriscuolo
Copy link

I am experiencing the same problem. Have someone come up with a solution?

Thanks!

@micahwilhelm
Copy link

I've found the same problem. Will someone from rstudio please comment if this bug will be fixed?

@aavanesy
Copy link

Please update us on this.

@barengb
Copy link

barengb commented May 21, 2021

I'm experiencing the same/similar problem. I don't succeed in adapting the colors of the marker-clusters when using leafletProxy, nor when using the iconCreateFunction, nor when trying it via CSS. Would be great if this can be solved. Thanks for your efforts!

jcheng5 added a commit that referenced this issue Sep 22, 2021
schloerke pushed a commit that referenced this issue Sep 22, 2021
jcheng5 added a commit that referenced this issue Sep 22, 2021
* Allow leafletProxy arguments to contain JS()

Fixes #420, #440

* Pass tests

* Use version of htmlwidgets that exports JSEvals

* Fix incorrect arg/evals validation

* More efficient JS() serialization for leafletProxy

Also, use snapshot testing for remote unit tests

* Remove htmlwidgets from Remotes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants