update markercluster->v0.1.1, leaflet-measure->2.1.7, leaflet-omnivore->0.3.4

[timelyportfolio]

I updated

• leaflet-markerCluster - All seems to work except for freezeAtZoom using example
• leaflet-measure - think all good
• leaflet-omnivore - tried and doesn't seem to work

  topoData <- readLines("https://d3js.org/us-10m.v1.json") %>% paste(collapse = "\n")
  
  leaflet() %>% setView(lng = -98.583, lat = 39.833, zoom = 3) %>%
    addTiles() %>%
    addTopoJSON(topoData, weight = 1, color = "#444444", fill = FALSE)
  

[bhaskarvk]

There were 2 sub plugins of the marker cluster plugin.
https://github.com/ghybs/Leaflet.MarkerCluster.LayerSupport To support Layer Group Control + Clustering &
https://github.com/ghybs/Leaflet.MarkerCluster.Freezable To support Freezing.
You probably need to upgrade them both too.

[timelyportfolio]

@bhaskarvk, I updated both this morning, and I don't see any API changes, but for some reason, freezeAtZoom is not working. Here is the freeze example from the plugin where it is working with Leaflet 1.0.1

I'll keep trying.

[timelyportfolio]

@bhaskarvk, I just figured it out. freeze and layersupport don't work together. If I use markerClusterGroup() instead of markerClusterGroup.layerSupport, then freezeAtZoom works correctly. I will try to debug to submit pull or at a minimum file a detailed issue.

Filed ghybs/Leaflet.MarkerCluster.LayerSupport#13.

[timelyportfolio]

... but (maybe @bhaskarvk can help) I just discovered that the easyButton example freeze works. This could be that it uses markerCluster directly instead of layersupport.

[bhaskarvk]

@timelyportfolio If I have to chose between freeze support or layersupport I would chose layersupport.. The layersupport plugin is crucial for supporting clustering + layers. I think that is more important to have than freezeAtZoom.
Also in 0.7.x the freezeAtZoom + layerSupport was working perfectly fine, so it's probably best to raise an issue w/ these plugin author/s to see why it's not working in 1.2.0.

[timelyportfolio]

@bhaskarvk I got a very quick response from the author with a workaround (ghybs/Leaflet.MarkerCluster.LayerSupport#13), but I'm not sure we will want to include. I tend to agree layer support is more important than freezable.

[bhaskarvk]

@timelyportfolio Why are you unsure about including the fix ?

[bhaskarvk]

I am fine with using a fixed plugin. I have had to do that in past too for some of the plugins in both leaflet and leaflet.extras. @timelyportfolio could you add the fix to this PR and I can test it out.

[timelyportfolio]

Thanks @bhaskarvk I hope to get this done by end of the weekend.

[timelyportfolio]

@bhaskarvk, I finally got it to work using ghybs/Leaflet.MarkerCluster.Freezable@d395303 and changing the order of the load/dependencies commit.

Please test if you get a chance.

I believe this leaves only leaflet-omnivore, leaflet.awesome-markers, leaflet-locationfilter, leaflet-providers-plugin as unresolved. These are listed in #453 (comment).

[timelyportfolio]

@bhaskarvk, have you had a chance to look at this? Thanks.

[bhaskarvk]

I will look over this over the coming weekend. Promise!

[bhaskarvk]

I will review this tonight and merge in the 1.x branch

[bhaskarvk]

Almost ready https://github.com/bhaskarvk/leaflet/tree/upgrade/leaflet-v1.x,
I've merged #453, #458, upgraded some more plugins, verified all examples.
Some minor issues to be ironed out, once I do that I'll give you a PR.

[bhaskarvk]

I've merged this in my https://github.com/bhaskarvk/leaflet/commits/upgrade/leaflet-v1.x and will be pushed as part of LeafletJS 1.x upgrade.

[bhaskarvk]

Superseded by #476, but keeping open for tracking purposes.

[schloerke]

This code has been merged into master #492. Closing. Thank you!!