Fix empty exercise code execution error #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcheng5
approved these changes
May 28, 2019
cpsievert
added a commit
that referenced
this pull request
Jul 17, 2020
… is never actually returned (follow up to #235)
cpsievert
added a commit
that referenced
this pull request
Jul 29, 2020
* empty_results()'s html_output needs to req()-able; otherwise, a value is never actually returned (follow up to #235) * Refactor evaluate_exercise() and add exercise.error.checker for running a checker function on exercise evaluation errors, closes #356 * code review feedback * knitr fig options were actually needed * shorter tempfile pattern * docs * Provide an exercise.error.checker option * Document new exercise.error.checker option * update news
schloerke
pushed a commit
that referenced
this pull request
Jul 30, 2020
* empty_results()'s html_output needs to req()-able; otherwise, a value is never actually returned (follow up to #235) * Refactor evaluate_exercise() and add exercise.error.checker for running a checker function on exercise evaluation errors, closes #356 * code review feedback * knitr fig options were actually needed * shorter tempfile pattern * docs * Provide an exercise.error.checker option * Document new exercise.error.checker option * update news
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #216
If no user exercise code is submitted, then no work should be done. Only return and clear out the visible output.