Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polyglot UI #397

Merged
merged 14 commits into from
Sep 8, 2020
Merged

Polyglot UI #397

merged 14 commits into from
Sep 8, 2020

Conversation

schloerke
Copy link
Collaborator

@schloerke schloerke commented Jul 14, 2020 •
edited
Loading

Followup to #390

Incorporating changes from #310

PR task list:

  • Update NEWS
  • Add tests (if possible)
  • Update documentation with devtools::document()

Updates:

This was referenced Jul 14, 2020
Closed
Closed
@tvatter
Copy link

tvatter commented Sep 1, 2020

I so want to see this!

schloerke and others added 6 commits September 2, 2020 14:04
@schloerke
Merge branch 'master' into polyglot_ui
9420ed7 
* master:
  Add events to website (#423)
  Add a checker test with error as solution (#422)
  Fixes for learnr on external evaluator (#420)
  Add shinytest support (#407)
  Validate the ability to create an idb store (#417)
  Disable completion of R code inside quotes, closes #401 (#413)
  Bump version (#414)
  Save tutorial output to temp folder when tutorial folder does not have write permissions (#412)
  Throw an informative error if an exercise chunk is NULL (#411)
  Remove outdated exercise option
  Checking for exercise errors (#403)
  Add event handler system (#398)
  External evaluator fixes (#399)
@schloerke
Merge branch 'master' into polyglot_ui
40b5d87 
* master:
  Rewrite exercise checking section (#427)
  Remove exercise.error.checker in favor of exercise.error.check.code and -error-check chunks (#426)
@schloerke
Pass the engine through and display it
f44fc0b
@schloerke @cassws
If it is a non-r language, disable diagnostics and code completion
8f135b1 
Co-Authored-By: Cass (Z.) Wilkinson Saldaña <12399460+zoews@users.noreply.github.com>
@schloerke
Pass the engine through to the checking functions
b45f7ec
@schloerke
Update NEWS.md
80b707d
schloerke
schloerke commented Sep 2, 2020
View reviewed changes
R/exercise.R Show resolved Hide resolved
@schloerke schloerke requested a review from cpsievert September 2, 2020 19:58
@schloerke schloerke marked this pull request as ready for review September 2, 2020 19:58
cpsievert
cpsievert reviewed Sep 3, 2020
View reviewed changes
docs/exercises.Rmd Outdated Show resolved Hide resolved
cpsievert
cpsievert reviewed Sep 3, 2020
View reviewed changes
NEWS.md Outdated Show resolved Hide resolved
@schloerke @cpsievert
Use .toLowerCase()
39eb895 
Co-authored-by: Carson Sievert <cpsievert1@gmail.com>
schloerke
schloerke commented Sep 3, 2020
View reviewed changes
NEWS.md Outdated Show resolved Hide resolved
@schloerke schloerke merged commit 3460acb into master Sep 8, 2020
@schloerke schloerke deleted the polyglot_ui branch September 8, 2020 15:29
sjgknight pushed a commit to sjgknight/learnr that referenced this pull request Aug 10, 2021
@schloerke @cassws @cpsievert
Polyglot UI (rstudio#397)
ec8e48e 
Co-authored-by: Barret Schloerke <schloerke@gmail.com>
Co-authored-by: Cass (Z.) Wilkinson Saldaña <12399460+zoews@users.noreply.github.com>
Co-authored-by: Carson Sievert <cpsievert1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpsievert cpsievert cpsievert left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schloerke @tvatter @cpsievert