fixes rstudio/htmltools#30: when HTML code is empty, do not try to ba…

…se64 encode images
rstudio · Aug 7, 2015 · 0b61992 · 0b61992
1 parent d31f8bc
commit 0b61992
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/NEWS b/NEWS
@@ -1,3 +1,10 @@
+			      CHANGES IN markdown VERSION 0.7.8
+
+BUG FIXES
+
+   o fixed https://github.com/rstudio/htmltools/issues/30: markdownToHTML() did
+   not work with empty files (thanks, @VermillionAzure)
+
 			      CHANGES IN markdown VERSION 0.7.7
 
 BUG FIXES

diff --git a/R/renderMarkdown.R b/R/renderMarkdown.R
@@ -158,6 +158,7 @@ renderMarkdown <- function(
 
 
 .b64EncodeImages <- function(html) {
+  if (length(html) == 0) return(html)
   reg <- "<\\s*[Ii][Mm][Gg]\\s+[Ss][Rr][Cc]\\s*=\\s*[\"']([^\"']+)[\"']"
   m <- gregexpr(reg, html, perl = TRUE)
   if (m[[1]][1] != -1) {