-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use platform prefix by default #1435
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this going to break the cache for every existing linux user? Is that ok?
@@ -1,6 +1,13 @@ | |||
|
|||
# renv 0.18.0 (UNRELEASED) | |||
|
|||
* **Breaking Change**: `renv` now includes platform prefix in library paths |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* **Breaking Change**: `renv` now includes platform prefix in library paths | |
* **Breaking Change**: `renv` now includes platform prefix in cache paths |
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, the change effects both:
> renv:::renv_paths_library()
[1] "/home/kevin/.cache/R/renv/library/renv-3022e2f8/linux-ubuntu-jammy/R-4.1/aarch64-unknown-linux-gnu"
> renv:::renv_paths_cache()
[1] "/tmp/Rtmpoiba2M/renv-tempfile-2ac82649a830d/cache/v5/linux-ubuntu-jammy/R-4.1/aarch64-unknown-linux-gnu"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh so it's not just the cache that will break, but every existing project will need to re-install all packages? I think that's a pretty strong argument for adding some help to automate the transition.
Yeah, you're right... do you have an opinion on what we should do here? I suppose we could drop a symlink from the "old" cache location to the "new" cache location on startup, to ensure the previous cache location remains visible? |
Maybe this is too aggressive / dangerous for 1.0.0 -- let's punt on this one until we can invest the time to provided a guided migration. |
Yeah, that was my feeling too. |
Closes #1211.