Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to 4.1.0 #84

Closed
drfurtado opened this issue Feb 6, 2021 · 11 comments · Fixed by #136
Closed

Upgrade to 4.1.0 #84

drfurtado opened this issue Feb 6, 2021 · 11 comments · Fixed by #136
Labels
feature a feature request or enhancement next to consider for next release

Comments

@drfurtado
Copy link

drfurtado commented Feb 6, 2021

How do I upgrade to revealjs 4.1.0?

Much appreciated.

@ccamara
Copy link

ccamara commented Mar 4, 2021

I haven't tried before (to be honest, I do not know how to setup my environment to install and work with a customized/forked version of a library), but I'd try following this guideline https://revealjs.com/upgrading/ within the inst/ folder, where I believe is where reveal.js resides (which is still in the 3.3.0.1 version from four years ago)

@SamGuay
Copy link

SamGuay commented Mar 28, 2021

Hi @drfurtado!

Thanks for the pointer, @ccamara, I think I have a fully-working up to date version of the package! I had to change a couple more things, but I haven't encountered any problem so far with the presentation I am currently designing right now. I also added a couple more plugins for fun.

If you want to give it a try, you can have a look in my repo or you can simply install my forked package using the devtools package:

# install.packages("devtools") # uncomment this line to install the devtools package.
devtools::install_github("samguay/revealjs")

Feel free to give any feedback, it is the first time I try to update a package on my own!

@ccamara
Copy link

ccamara commented Mar 30, 2021

Hi @SamGuay ,

Glad to hear that! I have installed your version, and at first sight it seems to work fine, although I didn't manage to make speaker view work (usually it get's triggered by pressing S (https://revealjs.com/speaker-view/). I will test it more thoroughly when I can.

Also, you might want to create a Pull Request to this repo (I do not know how alive and how prone to accept PR it is, though)

@SamGuay
Copy link

SamGuay commented Mar 30, 2021

Thanks for the feedback! This was definitely a trial, I will have more time to clean my repo and make a clean PR this weekendish!

Speaker notes work on my end, but I did play with the template, so I'd have to double-check whether the speaker notes were enabled by default. I'll make sure the google fonts are also included as @karldw mentioned in #79.

In the meantime, here's a little upgrade I was able to produce, if you think that's a must, I can make it more portable and include it in the PR as well. It is not perfect yet, but it meets my need to highlight some lines in my presentation tomorrow!

test_highlight

@apreshill apreshill added the next to consider for next release label Jul 26, 2021
@apreshill
Copy link

apreshill commented Jul 26, 2021

We'll want to upgrade this package to v4.1.2: https://github.com/hakimel/reveal.js/releases/tag/4.1.2

@cderv this is because this most recent release includes:

"Theme properties are now available as CSS variables, making them easy to override."

Note that Pandoc 2.9.2.2 and later can use reveal.js 4.x: https://github.com/jgm/pandoc/wiki/Using-pandoc-to-produce-reveal.js-slides

@SamGuay
Copy link

SamGuay commented Jul 26, 2021

Apparently, I took a very long weekend 😄. I can work on upgrading to 4.1.2 and open a PR if you welcome them @apreshill ?

Thanks

@apreshill
Copy link

Yes @SamGuay PR's most welcome! We probably will not be able to review until September though. Also I note there is a relevant discussion about updating in this PR: #59

@drfurtado
Copy link
Author

drfurtado commented Aug 26, 2021

Hi @drfurtado!

Thanks for the pointer, @ccamara, I think I have a fully-working up to date version of the package! I had to change a couple more things, but I haven't encountered any problem so far with the presentation I am currently designing right now. I also added a couple more plugins for fun.

If you want to give it a try, you can have a look in my repo or you can simply install my forked package using the devtools package:

# install.packages("devtools") # uncomment this line to install the devtools package.
devtools::install_github("samguay/revealjs")

Feel free to give any feedback, it is the first time I try to update a package on my own!

@SamGuay,
It was working fine until today. Now, I get a blank page when rendered, even when trying to preview in browser. Any help would be greatly appreciated.

files:

test.Rmd

---
title: "Untitled"
---

## R Markdown

This is an R Markdown presentation. Markdown is a simple formatting syntax for authoring HTML, PDF, and MS Word documents. For more details on using R Markdown see <http://rmarkdown.rstudio.com>.

_output.yaml

revealjs::revealjs_presentation:
  self_contained: false
  reveal_plugins: ["chalkboard", "search", "zoom", "notes", "menu"]
  reveal_options:
      chalkboard:
        theme: whiteboard
  theme: sky
  highlight: pygments
  transition: slide
  center: false
  controls: true
  controlsTutorial: true
  disableLayout: true
  incremental: true

@drfurtado
Copy link
Author

Update
I can confirm that the problem is related to pandoc. The behavior described below started when I upgraded pandoc to 2.14.2. The problem was solved by reverting back to pandoc 2.14.0.

@cderv
Copy link
Collaborator

cderv commented Aug 30, 2021

@drfurtado

Can you open a new issue about this ? Specific to this Pandoc update, with the error message you get. We will look into it and try to adapt to Pandoc changes so that it works in both version. Also if you could try version 2.14.1 b/c they change some stuff in the template in this version.

Thank you !

@cderv cderv added feature a feature request or enhancement and removed enhancement labels Sep 15, 2021
@cderv cderv linked a pull request Oct 7, 2021 that will close this issue
2 tasks
@cderv
Copy link
Collaborator

cderv commented Oct 7, 2021

revealjs R package has been update to last reveal.js available which is 4.1.2

Main feature have been keep with (almost) no breaking change. See NEWS file.

Update was about the JS library only and no new feature are supported yet. So some features from revealjs 4.1.2 are not supported by the R package.

Hope it is fine.

Please help test that everything is working as expected. Thank you !

remotes::install_github("rstudio/revealjs")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement next to consider for next release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants