Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to reveal.js 4.1.2 #136

Merged
merged 30 commits into from
Oct 7, 2021
Merged

Update to reveal.js 4.1.2 #136

merged 30 commits into from
Oct 7, 2021

Conversation

cderv
Copy link
Collaborator

@cderv cderv commented Sep 27, 2021

This PR is about the update to new reveal js. This is a bug one (more than 200 files differences)

This is a major version upgrade - no hard breaking change (https://revealjs.com/upgrading/) but somes files were removed and other changed.

@cderv cderv linked an issue Oct 6, 2021 that may be closed by this pull request
@cderv
Copy link
Collaborator Author

cderv commented Oct 7, 2021

This PR includes local fonts now

However, I don't know if this is necessary to add them, it makes the package heavier and above CRAN limits.

We could offer steps or functions to make font local if one wants.

[skip ci]
@cderv cderv marked this pull request as ready for review October 7, 2021 15:07
@cderv cderv merged commit e1893ae into master Oct 7, 2021
@cderv cderv deleted the update-revealjs branch October 7, 2021 15:09
@cderv cderv linked an issue Oct 7, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update chalkboard & menu plugin Upgrade to 4.1.0
2 participants