Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R Markdown Websites no longer work with non html_document formats #1328

Closed
jjallaire opened this issue Apr 27, 2018 · 1 comment · Fixed by #1329
Closed

R Markdown Websites no longer work with non html_document formats #1328

jjallaire opened this issue Apr 27, 2018 · 1 comment · Fixed by #1329
Milestone
v1.10

Comments

@jjallaire
Copy link
Member

R Markdown Websites were originally designed to work with any HTML based format (so long as it supports the site_libs and self_contained options). However, a recent change intended to address this issue (#793) has broken this:

#1177

So now the feature which originally supported any HTML based format can only work with html_document.

The original issue #793 is certainly also a legitimate use case (rendering PDFs alongside HTML documents) but this particular fix is too drastic, so I think should be reverted in preference to another fix (PR to follow with the revert, I'm not at all sure what the alternate fix should be, perhaps instantiating the output format and checking it's formals before forwarding on those parameters?).
jjallaire added a commit that referenced this issue Apr 27, 2018
@jjallaire
don't force the use of html_document with render_site
59cdaae 
fixes #1328
@jjallaire jjallaire mentioned this issue Apr 27, 2018
Merged
@yihui yihui added this to the v1.10 milestone Apr 27, 2018
jjallaire added a commit that referenced this issue Apr 27, 2018
@jjallaire
don't force the use of html_document with render_site (#1329)
6adfd05 
* don't force the use of html_document with render_site

fixes #1328

* move output_options to correct call

* strip unsupported options passed in the output_options argument of render

* update NEWS
@rich-iannone rich-iannone mentioned this issue May 1, 2018
Merged
yihui pushed a commit that referenced this issue May 2, 2018
@rich-iannone @yihui
Add custom-made spinner replacement .gif (#1333)
3002c32 
* Add custom-made spinner replacement .gif

Fix #1328

* Replace loading .gif with smaller version

* Replace `rmd_loader.gif` with optimized version

* Modify text under loading spinner

* Modify placement of text in loading screen
yihui pushed a commit to RLesur/rmarkdown that referenced this issue Apr 1, 2019
@jjallaire @yihui
don't force the use of html_document with render_site (rstudio#1329)
a9917f9 
* don't force the use of html_document with render_site

fixes rstudio#1328

* move output_options to correct call

* strip unsupported options passed in the output_options argument of render

* update NEWS
yihui pushed a commit to RLesur/rmarkdown that referenced this issue Apr 1, 2019
@rich-iannone @yihui
Add custom-made spinner replacement .gif (rstudio#1333)
548e7a8 
* Add custom-made spinner replacement .gif

Fix rstudio#1328

* Replace loading .gif with smaller version

* Replace `rmd_loader.gif` with optimized version

* Modify text under loading spinner

* Modify placement of text in loading screen
@github-actions
Copy link

github-actions bot commented Nov 3, 2020

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue by following the issue guide (https://yihui.org/issue/), and link to this old issue if necessary.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.10
Development

Successfully merging a pull request may close this issue.

don't force the use of html_document with render_site rstudio/rmarkdown
2 participants
@jjallaire @yihui