Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pandoc will start deprecate --self-contained in future version #2382

Closed
cderv opened this issue Jun 15, 2022 · 9 comments
Closed

Pandoc will start deprecate --self-contained in future version #2382

cderv opened this issue Jun 15, 2022 · 9 comments
Labels
next to consider for next release

Comments

@cderv
Copy link
Collaborator

cderv commented Jun 15, 2022

Today --self-contained implies --standalone. Now --embed-resources will do the self contained mechanism but possibly without doing the standalone part.

Equivalent of using custom template today with --self-contained and

$body$

This will need to be handled in all our format function, possibly with change of argument name to go with Pandoc change, or just adding standalone in all format.

Context in

@IndrajeetPatil
Copy link

With Pandoc 2.19 out today, I can confirm that I am getting these warnings with rmarkdown::render():

[WARNING] Deprecated: --self-contained. use --embed-resources --standalone

@yihui yihui moved this from Backlog to Todo in R Markdown Team Projects Aug 4, 2022
@cderv
Copy link
Collaborator Author

cderv commented Aug 16, 2022

Yes thanks. We need to conditionally handle this now that Pandoc 2.19 is out. This is on the todo list

@yihui yihui moved this from Todo to In Progress in R Markdown Team Projects Aug 17, 2022
@yihui yihui closed this as completed in b86f18b Aug 18, 2022
Repository owner moved this from In Progress to Done in R Markdown Team Projects Aug 18, 2022
@yihui
Copy link
Member

yihui commented Aug 18, 2022

Should be fixed now. You may install and test the development version via

remotes::install_github('rstudio/rmarkdown')

Thanks!

@cderv
Copy link
Collaborator Author

cderv commented Aug 18, 2022

Thanks @yihui !

@yihui
Copy link
Member

yihui commented Aug 18, 2022

I worked on it because I received an email from CRAN yesterday telling me that they had upgraded (or tried to upgrade) to Pandoc 2.19 and saw this warning... We need to act sooner in future when we detect problems in the dev version of Pandoc, since it seems that CRAN tends to always install the latest version of Pandoc once it's released.

@cderv
Copy link
Collaborator Author

cderv commented Aug 18, 2022

This is really new to me and big news that they install the latest version of Pandoc now ! Thanks for sharing. It will be of interest to others I guess that rely on pandoc through R Markdown.

I agree that we should act sooner from now own. I was only following and opening issues as of now. As we don't really know when a new Pandoc version will be release and no information on the new version number they'll use, we'll have a to find a good way to add support for new thing conditionally. The recent update to nightly version number could help us.

I'll think about it, and we'll discuss.

yihui added a commit that referenced this issue Aug 18, 2022
@yihui
Copy link
Member

yihui commented Aug 18, 2022

no information on the new version number they'll use, we'll have a to find a good way to add support for new thing conditionally

We may condition on if (pandoc_version() > CURRENT_LATEST_VERSION); pandoc_available() uses >=, which won't work.


Actually I just made a change in pandoc_version() in 45c6802 so that we can be more precise and use pandoc_available('X.Y.Z.YYYY.MM.DD') as the condition.

@cderv
Copy link
Collaborator Author

cderv commented Aug 19, 2022

Great thanks. That will help !

Pandoc team does not write changelog on the fly but at once before release I think. I'll ask Albert.
We will need to watch out closer the PR merged in Pandoc also. I am already watching the repo but I'll pay attention more.

@github-actions
Copy link

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue by following the issue guide (https://yihui.org/issue/), and link to this old issue if necessary.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
next to consider for next release
Projects
Archived in project
Development

No branches or pull requests

3 participants