-
-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shiny_prerendered_option_hook
no longer works since xfun 0.38 version
#2469
Labels
bug
an unexpected problem or unintended behavior
Comments
Ah, too bad that I didn't discover this in the revdep checks. I'll fix it in a minute. Thank you so much! |
jonathan-g
added a commit
to jonathan-g/rmarkdown
that referenced
this issue
May 17, 2023
* rstudio/main: (25 commits) Add missing new param for the function collection re-document following fce12fb Remove no more needed YAML validation for ending : [ioslide] Only do the chcp setting with Pandoc before 2.0 (rstudio#2481) Add a `pandoc_metadata_file_arg` helper Add mention of webshot and webshot2 required for screenshot to be made start the next version CRAN release v2.21 fix rstudio#2469: use all(is_blank()) for xfun 0.38 Fix typo in error message Update CITATION.cff Fix GHA action regarding older pandoc (rstudio#2466) update citation workflow Update check pandoc daily Allow manual trigger of checks Bring back Pandoc version in workflow name Update lock workflow Prefer pak usage for dev version now Update GHA workflow adapt CITATION file ...
jonathan-g
added a commit
to jonathan-g/rmarkdown
that referenced
this issue
May 17, 2023
* jg-devel: (25 commits) Add missing new param for the function collection re-document following fce12fb Remove no more needed YAML validation for ending : [ioslide] Only do the chcp setting with Pandoc before 2.0 (rstudio#2481) Add a `pandoc_metadata_file_arg` helper Add mention of webshot and webshot2 required for screenshot to be made start the next version CRAN release v2.21 fix rstudio#2469: use all(is_blank()) for xfun 0.38 Fix typo in error message Update CITATION.cff Fix GHA action regarding older pandoc (rstudio#2466) update citation workflow Update check pandoc daily Allow manual trigger of checks Bring back Pandoc version in workflow name Update lock workflow Prefer pak usage for dev version now Update GHA workflow adapt CITATION file ...
This old thread has been automatically locked. If you think you have found something related to this, please open a new issue by following the issue guide (https://yihui.org/issue/), and link to this old issue if necessary. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Since the new version 0.38 of
xfun
and the modification of the functionxfun::is_blank
, this code no longer works :rmarkdown/R/shiny_prerendered.R
Line 487 in c2d165a
To have the same behavior, it should be replaced by
if (all(xfun::is_blank(options$code)))
as suggested in the NEWS.md of xfun package.Example :
Thank you in advance !
The text was updated successfully, but these errors were encountered: