Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shiny_prerendered_option_hook no longer works since xfun 0.38 version #2469

Closed
andreahgsin opened this issue Mar 24, 2023 · 2 comments
Closed
Labels
bug an unexpected problem or unintended behavior

Comments

@andreahgsin
Copy link

andreahgsin commented Mar 24, 2023

Since the new version 0.38 of xfun and the modification of the function xfun::is_blank, this code no longer works :

if (xfun::is_blank(options$code)) {

To have the same behavior, it should be replaced by if (all(xfun::is_blank(options$code))) as suggested in the NEWS.md of xfun package.

Example :

---
title: "Hello Prerendered Shiny"
output: html_document
runtime: shiny_prerendered
---

```{r, echo=FALSE}
sliderInput("bins", "Number of bins:", min = 1, max = 50, value = 30)
plotOutput("distPlot")
output$distPlot <- renderPlot({
  x <- faithful[, 2]  # Old Faithful Geyser data
  bins <- seq(min(x), max(x), length.out = input$bins + 1)
  hist(x, breaks = bins, col = 'darkgray', border = 'white')
})

Thank you in advance !

@yihui
Copy link
Member

yihui commented Mar 24, 2023

Ah, too bad that I didn't discover this in the revdep checks. I'll fix it in a minute. Thank you so much!

@yihui yihui moved this to Todo In Progress in R Markdown Team Projects Mar 24, 2023
@yihui yihui added the bug an unexpected problem or unintended behavior label Mar 24, 2023
@yihui yihui closed this as completed in c7fa3e4 Mar 24, 2023
@github-project-automation github-project-automation bot moved this from Todo In Progress to Done in R Markdown Team Projects Mar 24, 2023
jonathan-g added a commit to jonathan-g/rmarkdown that referenced this issue May 17, 2023
* rstudio/main: (25 commits)
  Add missing new param for the function collection
  re-document following fce12fb
  Remove no more needed YAML validation for ending :
  [ioslide] Only do the chcp setting with Pandoc before 2.0 (rstudio#2481)
  Add a `pandoc_metadata_file_arg` helper
  Add mention of webshot and webshot2 required for screenshot to be made
  start the next version
  CRAN release v2.21
  fix rstudio#2469: use all(is_blank()) for xfun 0.38
  Fix typo in error message
  Update CITATION.cff
  Fix GHA action regarding older pandoc (rstudio#2466)
  update citation workflow
  Update check pandoc daily
  Allow manual trigger of checks
  Bring back Pandoc version in workflow name
  Update lock workflow
  Prefer pak usage for dev version now
  Update GHA workflow
  adapt CITATION file
  ...
jonathan-g added a commit to jonathan-g/rmarkdown that referenced this issue May 17, 2023
* jg-devel: (25 commits)
  Add missing new param for the function collection
  re-document following fce12fb
  Remove no more needed YAML validation for ending :
  [ioslide] Only do the chcp setting with Pandoc before 2.0 (rstudio#2481)
  Add a `pandoc_metadata_file_arg` helper
  Add mention of webshot and webshot2 required for screenshot to be made
  start the next version
  CRAN release v2.21
  fix rstudio#2469: use all(is_blank()) for xfun 0.38
  Fix typo in error message
  Update CITATION.cff
  Fix GHA action regarding older pandoc (rstudio#2466)
  update citation workflow
  Update check pandoc daily
  Allow manual trigger of checks
  Bring back Pandoc version in workflow name
  Update lock workflow
  Prefer pak usage for dev version now
  Update GHA workflow
  adapt CITATION file
  ...
@github-actions
Copy link

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue by following the issue guide (https://yihui.org/issue/), and link to this old issue if necessary.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug an unexpected problem or unintended behavior
Projects
Archived in project
Development

No branches or pull requests

2 participants