fix(ioslides): Shiny-specific initialization #2516
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2514
Fixes rstudio/shiny#3894
Currently, ioslides waits for the
DOMContentLoaded
event to initialize the slides, assuming that the<slides>
markup will be there when that event happens.Beacuse the slides are loaded via dynamic UI with
uiOutput()
(not just the slides, but the app content for any Shiny app in R Markdown), and due to recent changes in Shiny, the dynamic UI isn't present in the DOM yet. This is due to recent changes in Shiny that make dynamic UI rendered asynchronous.This PR is a minimal fix that adds special initialization code for Shiny in the ioslides pandoc template and prevents the ioslides
slide-deck.js
from trying to initialize slides automatically in a shiny context.This works because the slides markup, including the new initialization code, are all added to the page at the same time, so by the time
loadDeck()
is called we have a strong guarantee that<slides>
is present.cc @cderv @cpsievert (I can't request reviewers)