Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(beamer): support latex_dependencies #2558

Merged
merged 7 commits into from
Jun 17, 2024
Merged

Conversation

atusy
Copy link
Collaborator

@atusy atusy commented Jun 14, 2024

closes #2478

Confirmed it works by the following script.

writeLines(
  c(
    '```{r}',
    'knitr::asis_output("", meta = list(rmarkdown::latex_dependency("longtable")))',
    '```',
    '\\begin{longtable}{r|r} \\hline speed & dist\\\\ \\hline 4 & 2\\\\ \\end{longtable}'
  ),
  "example.Rmd"
)

render("example.Rmd", beamer_presentation())

Copy link
Member

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@yihui yihui requested a review from cderv June 14, 2024 17:11
Copy link
Collaborator

@cderv cderv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thank you !

If possible it would be great to add some test.

Thanks!

@atusy
Copy link
Collaborator Author

atusy commented Jun 15, 2024

@cderv
Thanks for the suggestion. I added test cases for pre_processors of pdf_document and beamer_presentation.

Copy link
Collaborator

@cderv cderv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot !

Also for improving the testing - long overdue switch to version 3 thank you !

@cderv cderv merged commit 4b2f342 into rstudio:main Jun 17, 2024
17 of 18 checks passed
jonathan-g added a commit to jonathan-g/rmarkdown that referenced this pull request Aug 8, 2024
Merge remote-tracking branch 'rstudio/main' into jg-devel

# By Yihui Xie (10) and others
# Via GitHub
* rstudio/main:
  Fix Pandoc nightly install in GHA (rstudio#2559)
  feat(beamer): support latex_dependencies (rstudio#2558)
  start the next version
  CRAN release 2.27
  export S3 method
  rsconnect::deploySite() has combined the arguments account and server in the doc
  Update forum url (rstudio#2555)
  Fix regression w/ image path processing from absolute to relative (rstudio#2554)
  Update posit forum URL
  provide an option to set the `*_files/` directory suffix (rstudio#2550)
  start the next version
  CRAN release v2.26
  use _PACKAGE as recommended by roxygen2
  use \describe{} instead of \itemize{} (r-devel will warn against it)
  [GHA] Remove duplicate entry in matrix
  new r-lib/actions@v2 has newer setup-pandoc
  [GHA] New setup pandoc action (rstudio#2543)
  Correctly avoid writing to the input file when there are no preserved HTML chunks (rstudio#2535)
  Create FUNDING.yml
  Fix small grammatical error (rstudio#2533)

# Conflicts:
#	DESCRIPTION
#	R/publish_site.R
jonathan-g added a commit to jonathan-g/rmarkdown that referenced this pull request Aug 8, 2024
* jg-devel: (21 commits)
  Builds and passes R CMD CHECK.
  Fix Pandoc nightly install in GHA (rstudio#2559)
  feat(beamer): support latex_dependencies (rstudio#2558)
  start the next version
  CRAN release 2.27
  export S3 method
  rsconnect::deploySite() has combined the arguments account and server in the doc
  Update forum url (rstudio#2555)
  Fix regression w/ image path processing from absolute to relative (rstudio#2554)
  Update posit forum URL
  provide an option to set the `*_files/` directory suffix (rstudio#2550)
  start the next version
  CRAN release v2.26
  use _PACKAGE as recommended by roxygen2
  use \describe{} instead of \itemize{} (r-devel will warn against it)
  [GHA] Remove duplicate entry in matrix
  new r-lib/actions@v2 has newer setup-pandoc
  [GHA] New setup pandoc action (rstudio#2543)
  Correctly avoid writing to the input file when there are no preserved HTML chunks (rstudio#2535)
  Create FUNDING.yml
  ...
jonathan-g added a commit to jonathan-g/rmarkdown that referenced this pull request Aug 8, 2024
* rstudio/main:
  Fix Pandoc nightly install in GHA (rstudio#2559)
  feat(beamer): support latex_dependencies (rstudio#2558)
  start the next version
  CRAN release 2.27
  export S3 method
  rsconnect::deploySite() has combined the arguments account and server in the doc
  Update forum url (rstudio#2555)
  Fix regression w/ image path processing from absolute to relative (rstudio#2554)
  Update posit forum URL
  provide an option to set the `*_files/` directory suffix (rstudio#2550)
  start the next version
  CRAN release v2.26
  use _PACKAGE as recommended by roxygen2
  use \describe{} instead of \itemize{} (r-devel will warn against it)
  [GHA] Remove duplicate entry in matrix
  new r-lib/actions@v2 has newer setup-pandoc
  [GHA] New setup pandoc action (rstudio#2543)
  Correctly avoid writing to the input file when there are no preserved HTML chunks (rstudio#2535)
  Create FUNDING.yml
  Fix small grammatical error (rstudio#2533)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

beamer_presentation does not resolve latex_dependencies
3 participants