This repository has been archived by the owner on Nov 13, 2024. It is now read-only.
Rebranding #331
Merged
Rebranding #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whimsicallyson
requested review from
Lytol,
AshleyHenry15,
akshayshiv,
eduardocfalcao and
mmarchetti
|
@mmarchetti I added you to this review so that someone who has been involved with the rsconnect-jupyter repo in the past can take a look. If that's not you, let me know who I should tag instead! |
mmarchetti
approved these changes
Oct 3, 2022
|
note: there's a video here that I don't know anything about updating.... |
|
Found one instance of RStudio Connect in the docs:
|
|
@nkakade-rstudio I haven't been updating release notes/NEWS/similar things that are tied to a specific version, because it was still RStudio Connect whenever it was written! |
|
The changes on this PR are verified. Verified locally with rsconnect-jupyter build running. |
|
@Lytol linting issue I mentioned in our content engagement meeting |
AshleyHenry15
approved these changes
Nov 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates company name and grammar throughout. Additionally, adds CSS and header/footer overrides to docs in order to match other docs on the site. Updated screenshots in the docs as well.
Leaves historical references to RStudio Connect in NEWS intact.
Also not sure if I should loop any non-Content Engagement folks into these reviews? 🤷♀️
Connected to https://github.com/rstudio/connect/issues/21954
Testing Notes / Validation Steps
I'd recommend attempting to deploy a Jupyter notebook to Connect to make sure all relevant references to RStudio are switched to Posit, and building the docs and comparing the styling to docs.rstudio.com