-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Frontiers Article #211
Conversation
Merge remote-tracking branch 'upstream/master'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start. Thanks!
As the main issue with 34212a0#comments was that it didn't work on windows, how do you test the windows build with Travis w/o Appveyor and not having |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With TinyTeX and the R package tinytex, it should be rare that we still need to worry about (standard) LaTeX packages. As long as the test passes on Travis, the package should work equally well on Windows, because TinyTeX is cross-platform.
At the time when JJ said it didn't work on Windows, we didn't even enable Travis for this repo (he was manually testing it), and TinyTeX didn't exist.
I have manually tested it on Windows with TinyTeX anyway, and it worked fine. Thank you!
Figures which are not according to the guidelines will cause substantial delay | ||
during the production process. | ||
|
||
# Discussion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder why most section headers are unnumbered, but a few are numbered (by default).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good question. I was mainly working on the previous commit as a template and then just editing. I can change if necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just asking. I don't know the journal requirement. If the journal requires unnumbered sections, we can just do it via a global option (pdf_document(number_sections = FALSE)
), otherwise I won't use {-}
frequently throughout the example.
BTW, I really wish they could use |
I vote we remove the .jpg, convert eps to PDF and change the Edit: We should take out |
@@ -1,955 +1,955 @@ | |||
\newcommand\classname{frontiersSCNS} %this file is based in bioninfo.cls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these CRLF <-> LF
changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm - I edited in texMaker, so it may have done that without me realizing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should only be an edit to epstopdf
package exclusion and logo.pdf
Figures which are not according to the guidelines will cause substantial delay | ||
during the production process. | ||
|
||
# Discussion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just asking. I don't know the journal requirement. If the journal requires unnumbered sections, we can just do it via a global option (pdf_document(number_sections = FALSE)
), otherwise I won't use {-}
frequently throughout the example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please feel free to add frontiersHLTH.cls
and frontiersFPHY.cls
, and remove epstopdf
.
%%% In http://www.ctan.org/ you can find the packages and how to install them, if necessary. %%% | ||
%%% NB logo1.jpg is required in the path in order to correctly compile front page header %%% | ||
|
||
\documentclass[utf8]{frontiersSCNS} % for Science, Engineering and Humanities and Social Sciences articles |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make it possible for users to customize the document class, you can use $documentclass$
instead of hardcoding one: http://pandoc.org/MANUAL.html#variables-for-latex
https://github.com/jgm/pandoc-templates/blob/master/default.latex#L35
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added this to the options, so you can do:
output:
rticles::frontiers_article:
documentclass: frontiersHLTH
Thanks! |
To contribute a new article template to this package, please make sure you have done the following things (note that
journalname_article
below is only an example name):Unless you have done it in any other RStudio's projects before, please sign the individual or corporate contributor agreement for a significant pull request (it is fine not to sign it if a PR is only intended to fix a few typos). You can send the signed copy to jj@rstudio.com.
Add the Pandoc LaTeX template
inst/rmarkdown/templates/journalname_article/resources/template.tex
.Add a skeleton article
inst/rmarkdown/templates/journalname_article/skeleton/skeleton.Rmd
.Add a description of the template
inst/rmarkdown/templates/journalname_article/template.yaml
.Please include the document class file (
*.cls
) if needed, but please do not include standard LaTeX packages (*.sty
) that can be downloaded from CTAN. Please keep the number of new files absolutely minimal, and also make examples minimal (e.g., if you need a.bib
example, try to only leave one or two bibliography entries in it, and don't include one hundred items in it without using all of them).Update Rd and namespace (could be done by
devtools::document()
).Update NEWS.
Update README with a link to the newly supported journal.
Add a test to
tests/testit/test-formats.R
.Add your name to the list of authors
Authors@R
in DESCRIPTION. You don't need to bump the package version in DESCRIPTION.Thank you!