Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Statistics in Medicine template to latest version #231

Merged
merged 5 commits into from
Jun 12, 2019

Conversation

ellessenne
Copy link
Contributor

Hi @yihui,
I updated the Statistics in Medicine template (that I contributed in the past) to its latest version.
Thanks for your work on rticles!

Alessandro

Copy link
Member

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but could you not make the file mode changes from 644 to 755? Thank you!

@ellessenne
Copy link
Contributor Author

Hi @yihui, I modified file permissions to 644 (I think - I did not set permissions willingly, I guess it came this way from Wiley?): did I do it correctly?
Thanks!

Copy link
Member

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you did a perfect job! Please add a news item to NEWS.md, and I'll merge this PR. Thanks a lot!

@ellessenne
Copy link
Contributor Author

Done, and I took the opportunity to update my details in the DESCRIPTION file as well. Thanks!

@yihui yihui merged commit ce058dc into rstudio:master Jun 12, 2019
@yihui
Copy link
Member

yihui commented Jun 12, 2019

Excellent. Thank you!

@ellessenne ellessenne deleted the sim-update branch June 12, 2019 21:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants