-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new sass_html_dependencies() function for more convenient htmlDependency bundling #46
base: main
Are you sure you want to change the base?
Conversation
@@ -0,0 +1,58 @@ | |||
#' Compile Sass to CSS using LibSass, then return an HTML Dependencies | |||
#' | |||
#' Calls `sass(input, ...)` and wraps the output into a [htmltools::htmlDependency()]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#' Calls `sass(input, ...)` and wraps the output into a [htmltools::htmlDependency()]. | |
#' Calls `sass(input, ...)` and wraps the output into a list of [htmltools::htmlDependency()]s. |
#' stylesheet = "my-style.css" | ||
#' )) | ||
sass_html_dependencies <- function( | ||
input, name, version, stylesheet, cache_key = NULL, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's kind of confusing how the htmlDependency
args are interleaved with the sass
args, and that the order of the htmlDependency
args aren't even the same as in the htmlDependency
function.
One possibility: maybe all of the htmlDependency
args should go after ...
? We can also discuss other ways to go about this.
ae3a082
to
7dd9962
Compare
Update: this idea might be worth returning to if we decide to return to the idea of "run-time" html dependencies. |
No description provided.