-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
loadSupport(): fix global.R support, run global.R in appropriate dir #2831
Conversation
I think the other files, in the R/ directory, need to be sourced in the app directory as well, though this should be checked first to make sure it's the correct behavior. |
@wch I think you're right, I'll fix it up. |
I did some experimentation with |
…adSupport() and findEnclosingApp()
@wch apprised me of r-lib/roxygen2#1077 and we now sort files from R/ using |
global.R
support was broken as a result our changes to theappDir
argument; this fixes it.require(shiny)
soshiny::loadSupport()
works.global.R
is evaluated in the app directory instead of whichever directoryloadSupport()
was called in.on.exit()/setwd()
with awithr::with_dir()
R/
is sourced is now given bysort(..., method="radix")
which aligns with R conventionsfindEnclosingApp()
now usesfile.path.ci()
internally so it now works on case-insensitive file systems (tested by mounting fat32 loopback disk on Linux)These items came up preparing https://github.com/CRI-iAtlas/shiny-iatlas for module testing.