Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootstrap 5 support #3410

Merged
merged 4 commits into from
Jun 2, 2021
Merged

Bootstrap 5 support #3410

merged 4 commits into from
Jun 2, 2021

Conversation

cpsievert
Copy link
Collaborator

@cpsievert cpsievert commented Jun 1, 2021 •
edited
Loading

Adds Bootstrap 5 compatibility (which will be added to {bslib} in rstudio/bslib#304) for selectInput(), modals, and showcases. It may grow to include other changes as more testing it done.

Note that navs also need the data-bs-* treatment, but that'll happen via #3388 and rstudio/bslib#304

@cpsievert cpsievert mentioned this pull request Jun 1, 2021
Closed
@cpsievert cpsievert changed the base branch from updateSelectize to master June 1, 2021 22:45
@cpsievert cpsievert mentioned this pull request Jun 1, 2021
Merged
2 tasks
@cpsievert cpsievert marked this pull request as ready for review June 1, 2021 22:54
@cpsievert cpsievert requested a review from wch June 1, 2021 22:54
cpsievert
cpsievert commented Jun 1, 2021
View reviewed changes
R/modal.R Show resolved Hide resolved
@cpsievert cpsievert merged commit 4deb699 into master Jun 2, 2021
@cpsievert cpsievert deleted the bs5 branch June 2, 2021 17:36
@cpsievert cpsievert mentioned this pull request Jun 2, 2021
Closed
cpsievert added a commit that referenced this pull request Jun 2, 2021
@cpsievert
Follow up to #3410: bump version and update news
822de48
@cpsievert cpsievert mentioned this pull request Jun 2, 2021
Merged
cpsievert added a commit that referenced this pull request Jun 2, 2021
@cpsievert
Follow up to #3410: bump version and update news
0ce9323
cpsievert added a commit that referenced this pull request Jun 2, 2021
@cpsievert
Follow up to #3410: bump version and update news (#3411)
871b1ba
schloerke added a commit that referenced this pull request Jun 2, 2021
@schloerke
Merge branch 'master' into barret/ts_iteration_2
c615c58 
* master:
  Fix tab input value updating for BS4 dropdowns (#3412)
  Follow up to #3410: bump version and update news (#3411)
  Bootstrap 5 support (#3410)
  Use bslib's new nav() api to implement tabPanel() and friends (#3388)
@cpsievert cpsievert mentioned this pull request Jun 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wch wch wch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpsievert @wch