chore: Enable return of dependency CSS as Sass files #4044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes it possible to extract the Sass files prior to compilation for the following CSS: * shiny * selectize * ionrangeslider * daterange picker
cpsievert
reviewed
May 6, 2024
R/input-date.R
Outdated
Comment on lines
156
to
160
| datePickerSassLayer <- function() { | ||
| sass::sass_file( | ||
| system_file(package = "shiny", "www/shared/datepicker/scss/build3.scss") | ||
| ) | ||
| } |
There was a problem hiding this comment.
I think I'd prefer Layer to not be in the name since I'd expect it to return a sass::sass_layer().
There was a problem hiding this comment.
Sure. I used that because 1. It's not clear to me what exactly a sass layer is and 2. in bslib we already had component_dependency_sass() which compiles Sass but actually returns an HTMLDependency.
6 tasks
cpsievert
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to extract the Sass files prior to compilation for the following CSS:
shinyDependencySassLayer()selectizeSassLayer()ionRangeSliderDependencySassLayer()datePickerSassLayer()The naming might look inconsistent, but there's a method: I added a new function adjacent to the
____CSS()function for each component, replacingCSSwithSassLayer.This is an internal-facing refactor to support dynamic theming in Shiny for Python, where we need access to the pre-compiled Sass files for each dependency.
Pairs with: