Set typescript.tsdk so VSCode's TS language features work properly

[dvg-p4]

EDIT 2: Setting the typescript version in the UI actually just creates this line in the settings.json file under the hood.

EDIT 3: but it seems to keep the right version even if you subsequently revert that change to settings.json ???

---

EDIT: The real solution to the problem I was having was simply to configure the TypeScript version used, via VSCode UI. Hit the braces on the bottom right:

Then "Select Version":

Then "Use Workspace Version".

---

This prevents spurious linting warnings, and makes type detection work properly with the complex constructions used in some places.

[gadenbuie]

This prevents spurious linting warnings, and makes type detection work properly

I think there might be something particular to your local setup that's involved here. I don't see any lint errors in VS Code currently.

[dvg-p4]

Do you have TypeScript > Validate enabled or disabled?

[dvg-p4]

Also, if you open up this line in VSCode:

shiny/srcts/src/bindings/input/selectInput.ts

Line 204 in abf7138

} else if (hasDefinedProperty(data, "value")) {

and hover over data, does it show

or....never mind, I can't seem to reproduce the old behavior anymore, even after switching back to main. But it used to say data: never before I started messing with the settings.

[dvg-p4]

Ahhh I see. On the bottom right:

If I click "Select Version":

With "Use VS Code's Version" I get the errors:

But with "Use Workspace Version" everything works properly:

[dvg-p4]

Messing with the settings appears to have kicked my VS Code into the "use workspace version" state, but is not generally needed to do so, since apparently there's an actual menu 🤦‍♂️.

[dvg-p4]

...actually it turns out, selecting the setting in the UI just automatically adds this line to to the project's settings.json file. So this does need to be here for it to work right (I think?)

[dvg-p4]

...but if I revert the change to settings.json and reload VSCode then it keeps using the right version anyways???