Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freeze/thaw tests #78

Merged
merged 3 commits into from
Oct 14, 2020
Merged

freeze/thaw tests #78

merged 3 commits into from
Oct 14, 2020

Conversation

jcheng5
Copy link
Member

@jcheng5 jcheng5 commented Oct 7, 2020

Tests for rstudio/shiny#3055

Comments to come
There are three scenarios described here:
rstudio/shiny#3055

App 207-freeze-invalidate tests Bug 1 and 3.
@jcheng5 jcheng5 marked this pull request as ready for review October 7, 2020 21:27
@jcheng5 jcheng5 requested a review from wch October 8, 2020 23:22
@jcheng5
Copy link
Member Author

jcheng5 commented Oct 8, 2020

I don't know why the CI tests are failing, but I'm pretty sure they aren't because of my changes

@schloerke
Copy link
Contributor

I have run the apps on my machine and they behave as expected on Chrome.
LGTM

@jcheng5 jcheng5 merged commit c48f850 into master Oct 14, 2020
@jcheng5 jcheng5 deleted the joe-freeze-thaw branch October 14, 2020 16:37
@jcheng5
Copy link
Member Author

jcheng5 commented Oct 14, 2020

Thanks @schloerke!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants