bslib::accordion() tests
#152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
changed the title
bslib::accordion()bslib::accordion() tests
cpsievert
commented
Mar 6, 2023
inst/apps/306-accordion-add-remove/tests/testthat/test-shinytest2.R
Outdated
Show resolved
Hide resolved
5 tasks
|
The Mac 3.6 failure is due to terra https://github.com/rstudio/shinycoreci/actions/runs/4348272330/jobs/7596698605#step:12:8484 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two tests:
306-accordion-add-remove: This app primarily testsaccordion_panel_insert(),accordion_panel_remove(),accordion_panel_set(), andaccordion_panel_open(). It also takes screenshots (instead of testing markup) since it implicitly depends on compliance with Bootstrap markup. Note that we also use anaccordion()inside asidebar()here to ensure it renders flush with the sidebar.307-accordion-replace: Primarily testsaccordion_panel_update()