fix(test-duplicate-ids): Check for duplicates instead of app start fa…

…ilure (#384)
rstudio · Apr 12, 2024 · 967b669 · 967b669
1 parent 436535d
commit 967b669
Showing 1 changed file with 10 additions and 5 deletions.
diff --git a/tests/testthat/test-app-duplicate-ids.R b/tests/testthat/test-app-duplicate-ids.R
@@ -50,7 +50,7 @@ test_that("Duplicate input/output ids are found", {
 
 
 
-test_that("Duplicate output ids are found", {
+test_that("Duplicate custom output ids are found", {
 
   shiny_app <- shinyApp(
     ui = fluidPage(
@@ -74,7 +74,7 @@ test_that("Duplicate output ids are found", {
 })
 
 
-test_that("Duplicate input ids are found", {
+test_that("Duplicate shiny output ids are found", {
   shiny_app <- shinyApp(
     ui = fluidPage(
       # Duplicate output IDs causes failure to load application
@@ -87,8 +87,13 @@ test_that("Duplicate input ids are found", {
     }
   )
 
-  expect_error(
-    AppDriver$new(shiny_app, load_timeout = 2000),
-    "Shiny app did not become stable"
+  expect_warning(
+    app <- AppDriver$new(shiny_app, check_names = TRUE),
+    "html"
+  )
+
+  expect_failure(
+    app$expect_unique_names(),
+    "html"
   )
 })