fix: Downgrade mustExist errors to a warning
#385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #330
As described in the issue,
globals::globalsOf(mustExist = TRUE)sometimes has false positives, for metaprogramming issues or when encountering a symbol that is defined later but that would be valid at runtime.This PR downgrades
mustExisterrors to a warning message. Doing so requires two calls toglobals::globalsOf():The first call uses
mustExist = FALSE. Ignoring potentially non-existant globals might lead to other errors that are masked by themustExist = TRUEcase.The second call uses
mustExist = TRUE. If an error occurs at this step, then we downgrade "failed to locate" errors to a warning, otherwise we rethrow.