Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace crayon by cli #399

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Replace crayon by cli #399

merged 2 commits into from
Feb 10, 2025

Conversation

olivroy
Copy link
Contributor

@olivroy olivroy commented Dec 12, 2024

For coloring messages

gadenbuie
gadenbuie approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@gadenbuie gadenbuie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I like that this opens the door for us to switch to using cli for errors and messages.

@gadenbuie
Copy link
Member

Please add a NEWS item so that we can attribute the change to you.

@schloerke schloerke merged commit 596ecf6 into rstudio:main Feb 10, 2025
17 of 18 checks passed
schloerke added a commit that referenced this pull request Feb 10, 2025
@schloerke
Merge branch 'main' into pkg_support
6b4109f 
* main:
  Replace crayon by cli (#399)
schloerke added a commit that referenced this pull request Feb 10, 2025
@schloerke
Merge branch 'main' into pkg_test_env
918664e 
* main:
  Replace crayon by cli (#399)
  ci: Use actions/upload-artifacts@v4 (#398)
  Change message load_timeout (#394)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gadenbuie gadenbuie gadenbuie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olivroy @gadenbuie @schloerke