Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add an optional running header to be different than the title #82

Merged
merged 3 commits into from
Sep 30, 2020
Merged

add an optional running header to be different than the title #82

merged 3 commits into from
Sep 30, 2020

Conversation

cderv
Copy link
Collaborator

@cderv cderv commented Sep 25, 2020

It seems easy to add this one that close #25

Is it in time for the release ?

@cderv cderv requested a review from yihui September 25, 2020 16:22
yihui
yihui approved these changes Sep 30, 2020
View reviewed changes
Copy link
Member

@yihui yihui left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't notice this PR.

It will also close #26.

@cderv
Copy link
Collaborator Author

cderv commented Sep 30, 2020

Oh I missed that it was already done in #26 🤦 ... as it was not linked in the issue.

@cderv cderv merged commit 4175791 into rstudio:master Sep 30, 2020
@cderv cderv deleted the runningheader branch September 30, 2020 08:29
cderv added a commit that referenced this pull request Sep 30, 2020
@cderv
0.7 is already on CRAN so #82 is for next version
4000432
@cderv cderv mentioned this pull request Sep 30, 2020
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yihui yihui yihui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running title/short title
2 participants
@cderv @yihui