Fix Multithreaded Scene Loading #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsubtil
requested changes
Mar 25, 2024
There was a problem hiding this comment.
Thank you for your contribution!
The changes makes sense, but I'd like to test if it's possible to maintain the current behavior and instead detect a multi-threaded scenario to then call it as deferred. The current proposed solution leaves the texture path uninitialized for the first frame, which in some scenarios causes errors, like when embedding on a RichTextLabel:
rsubtil
approved these changes
Mar 25, 2024
|
Thank you so much for your contribution! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I hope you don't mind, but I noticed that when loading scenes from threads that contain ControllerIcon textures I would get crashes. (https://docs.godotengine.org/en/stable/tutorials/io/background_loading.html)
This PR fixes the crash by ensuring the texture load happens on the main thread.
I also updated the import file for steamdeck dpad_right to match the other import files.