Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROS 2 Jazzy対応 #62

Merged
merged 30 commits into from
Nov 25, 2024
Merged

ROS 2 Jazzy対応 #62

merged 30 commits into from
Nov 25, 2024

Conversation

KuraZuzu
Copy link
Contributor

@KuraZuzu KuraZuzu commented Nov 20, 2024 •
edited
Loading

What does this implement/fix?

ROS 2 Jazzyに対応します。

Does this close any currently open issues?

しません。

How has this been tested?

基本的にはREADMEの手順に沿い、各項目の動作を確認しました。

環境

  • Raspberry Pi Mouse V3
    • Raspberry Pi 4B (4GB)
    • OS: Ubuntu Server 24.04 (kernel: 6.8.0-1013-raspi)
    • ROS 2 Jazzy base
  • Remote PC
    • OS: Ubuntu Desktop 24.04 (kernel: 6.8.0-49-generic)
    • ROS 2 Jazzy desktop

実施項目

README.mdにある各項目を実施して動作確認しました。

  • joystick_control
  • object_tracking
  • line_follower
  • camera_line_follower
  • direction_controller

Any other comments?

Checklists

@KuraZuzu
The header file "cv_bridge.h" in the cv_bridge package has been renam…
32258fe 
…ed to "cv_bridge.hpp". This change has been applied to all corresponding "#include" statements.
@KuraZuzu
Replaced "Twist" with "TwistStamped" in "joystick_control.py"
e42f8de
@KuraZuzu
Replaced "Twist" with "TwistStamped" for "camera_line_follower.launch…
b051ed5 
….py"
@KuraZuzu
Replaced "Twist" with "TwistStamped" for "object_tracking.launch.py"
9e0cf80
@KuraZuzu
Replaced "Twist" with "TwistStamped" (Changed in all instances, rever…
1bc80b5 
…t if any unexpected issues occur, "revert").
@KuraZuzu
Modify CI to ensure compatibility with the act tool
3480ac9
@KuraZuzu
Add author
fefd643
@KuraZuzu
Update README for Support Jazzy
5bb5d4a
@KuraZuzu
Add CI settings for Rolling
5996db3
@KuraZuzu
Revert "Add CI settings for Rolling"
00a8b6a 
This reverts commit 5996db3.
@KuraZuzu
Replace ROS_REPO: [ros] with ROS_REPO: [main]
7b7a517
@KuraZuzu
Add rosinstall for CI
b9605cd
@KuraZuzu
Adapt clang-format with Google style
0a42043
@KuraZuzu
Fix order of include in c file
356a417
@KuraZuzu
Revert "Add rosinstall for CI"
a06b8a9 
This reverts commit b9605cd.
@KuraZuzu
Reapply "Add rosinstall for CI"
37db57d 
This reverts commit a06b8a9.
@KuraZuzu
Revert "Fix order of include in c file"
8797078 
This reverts commit 356a417.
@KuraZuzu
Revert "Adapt clang-format with Google style"
304f82b 
This reverts commit 0a42043.
@KuraZuzu
fix typo of distribution name
6c632e6
@KuraZuzu
Applied "ament_clang_format" and passed cpplint, with manual adjustme…
2c1d411 
…nts made to the "include" order
@KuraZuzu
Adapted ruff formetter
0c851db
@KuraZuzu
fix "import" module order
3e395d3
@KuraZuzu
Adaptted "ament_uncrustify"
182da8d
@KuraZuzu
Update README.en.md fo Jazzy
26f8117
@KuraZuzu KuraZuzu added the Type: Feature New Feature label Nov 20, 2024
@KuraZuzu KuraZuzu self-assigned this Nov 20, 2024
@KuraZuzu KuraZuzu requested a review from YusukeKato November 20, 2024 07:29
@KuraZuzu KuraZuzu removed their assignment Nov 20, 2024
@KuraZuzu KuraZuzu self-assigned this Nov 20, 2024
YusukeKato
YusukeKato requested changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@YusukeKato YusukeKato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

レビューコメントの確認をお願いいたします。

include/raspimouse_ros2_examples/camera_line_follower_component.hpp Show resolved Hide resolved
include/raspimouse_ros2_examples/visibility_control.h Outdated Show resolved Hide resolved
package.xml Outdated Show resolved Hide resolved
@KuraZuzu
Copy link
Contributor Author

レビューありがとうございました。レビューでご指摘いただいた点を修正しました。

@YusukeKato
Copy link
Contributor

YusukeKato commented Nov 22, 2024 •
edited
Loading

修正ありがとうございます。
すべてのサンプルで動作確認できました！

@YusukeKato
Copy link
Contributor

カメラのライントレースでもカメラの露光やホワイトバランスの調整が必要な場合があるため注意書きを追記していただきたいです。

例：ラインの検出精度が悪い場合はカメラの露光やホワイトバランスの調整を行ってください

@KuraZuzu
Copy link
Contributor Author

KuraZuzu commented Nov 22, 2024 •
edited
Loading

ラインの検出精度が悪い場合はカメラの露光やホワイトバランスの調整を行ってください

こちら、そのまま追記させていただきました。英語のREADMEも追記しました。

@YusukeKato
Copy link
Contributor

修正ありがとうございます。
LGTMです！

@YusukeKato YusukeKato merged commit b0ac055 into master Nov 25, 2024
1 check passed
@YusukeKato YusukeKato deleted the feature/support-jazzy branch November 25, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YusukeKato YusukeKato YusukeKato requested changes

Assignees

@KuraZuzu KuraZuzu

Labels
Type: Feature New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KuraZuzu @YusukeKato