✨Bento amp-wordpress-embed
#2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradeep910
reviewed
Jun 21, 2021
ediamin
force-pushed
the
add/amp-wordpress-embed
branch
from
aa8983b to
66c0b6e
Compare
Co-authored-by: Caroline Liu <10456171+caroqliu@users.noreply.github.com>
Co-authored-by: Weston Ruter <westonruter@google.com>
Co-authored-by: Weston Ruter <westonruter@google.com>
Co-authored-by: Weston Ruter <westonruter@google.com>
Co-authored-by: Weston Ruter <westonruter@google.com>
Co-authored-by: Weston Ruter <westonruter@google.com>
AnuragVasanwala
pushed a commit
that referenced
this pull request
Jul 1, 2021
…mpproject#35023) * Add runtime service to handle execute tasks like adding ports to the network. - Add entry points to wrapper such as creating PortOperator and adding ports. - Update compile script since it can perform as normal Closure compiler. * Fix lint errors. * Remove externs.js since the compiled code with it would keep 'goog' hence violate JSC_CANNOT_HAVE_MODULE_VAR_NAMED_GOOG. * Construct channel with FrameService iframe and add it to the network. - Add DeferredChannel to the network first and resolve it after the real channel is constructed. - Ensure FrameService port is always added before any widget initialization * Report available widgets to FrameService so that it can request widget ports to listen on. - Add protocol buffer library to generate FrameService protocol - Report widget by sending messages to FrameService's RespondingChannel. - Add necessary endpoints to Closure custom API. * Move proto library to third_party folder. - Move entire proto folder to third_party folder - Update whitelist and source globs for new third_party library - Add exports file so that 'require' can be avoided in the extension * Fix source glob error. * Fix source glob error #2. * Update protoc from protobug Github repo. * Remove assistjs extension and all relevant libraries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a bento component for
amp-wordpress-embed.amp-wordpress-embedamp-wordpress-embedThis PR solves the issues described in ampproject#18378
wp-embed-template.js.Fixes ampproject#18378