Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-333: Fatal Error on Empty Redis Port Setting in Nginx Helper Plugin [Master] #335

Merged
merged 2 commits into from
Apr 15, 2024
Merged

GH-333: Fatal Error on Empty Redis Port Setting in Nginx Helper Plugin [Master] #335

merged 2 commits into from
Apr 15, 2024

Conversation

Pathan-Amaankhan
Copy link
Member

Description

  • This PR adds functionality to re-populate the empty text input fields with their default values at the time of save.
  • This will ensure that we will never have any empty text input field & will never get a fatal error due to an empty text input field.

Fixes/Covers

@Pathan-Amaankhan Pathan-Amaankhan self-assigned this Apr 12, 2024
@Pathan-Amaankhan Pathan-Amaankhan marked this pull request as ready for review April 12, 2024 13:43
Base automatically changed from feature/skip-feeds-option to master April 15, 2024 09:25
@Pathan-Amaankhan Pathan-Amaankhan merged commit 80c589d into master Apr 15, 2024
2 of 3 checks passed
@Pathan-Amaankhan Pathan-Amaankhan deleted the fix/GH-333 branch April 15, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gagan0123 gagan0123 gagan0123 approved these changes

Assignees

@Pathan-Amaankhan Pathan-Amaankhan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pathan-Amaankhan @gagan0123