Add Purge for AMP URL when a Post or Page is Published. #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SH4LIN
requested changes
Oct 14, 2024
| </span> | ||
| </legend> | ||
| <label for="purge_amp_urls"> | ||
| <input type="checkbox" value="1" id="purge_amp_urls" name="purge_amp_urls" <?php checked( $nginx_helper_settings['purge_amp_urls'], 1 ); ?> /> |
There was a problem hiding this comment.
@SH4LIN I have enabled it in accordance with the default behaviour since, by default, all other options—aside from comments—are enabled when purge is enabled.
admin/class-fastcgi-purger.php
Outdated
| * @param string $url_base The base URL to purge. | ||
| */ | ||
| private function purge_amp_version( $url_base ) { | ||
| $amp_url = $url_base . '/amp/'; |
admin/class-fastcgi-purger.php
Outdated
|
|
||
| $this->log('- Purging AMP URL | ' . $amp_url); | ||
|
|
||
| if ($this->nginx_helper_admin->options['purge_method'] === 'unlink_files') { |
There was a problem hiding this comment.
Use Yoda condition and add spaces at start and end of the brackets
SH4LIN
requested changes
Dec 4, 2024
admin/class-fastcgi-purger.php
Outdated
| private function purge_amp_version( $url_base ) { | ||
| $amp_url = sprintf( '%s/amp/', rtrim( $url_base, '/' ) ); | ||
|
|
||
| $this->log('- Purging AMP URL | ' . $amp_url); |
There was a problem hiding this comment.
Fix the PHPCS error here.
Suggested change
| $this->log('- Purging AMP URL | ' . $amp_url); | |
| $this->log( '- Purging AMP URL | ' . $amp_url ); |
| <tr valign="top"> | ||
| <th scope="row"> | ||
| <h4> | ||
| <?php esc_html_e( 'Purge AMP URL:', 'nginx-helper' ); ?> |
| <td> | ||
| <fieldset> | ||
| <legend class="screen-reader-text"> | ||
| <span> |
| <label for="purge_amp_urls"> | ||
| <input type="checkbox" value="1" id="purge_amp_urls" name="purge_amp_urls" <?php checked( $nginx_helper_settings['purge_amp_urls'], 1 ); ?> /> | ||
| | ||
| <?php |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The aim of this PR is to add support for purging AMP URL's.
Type
Reference Issue
Testing
The code has been tested locally and is working as expected.