Sync Develop branch with Master #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pathan-Amaankhan
requested changes
Oct 21, 2024
admin/class-nginx-helper-admin.php
Outdated
| $all_urls = array(); | ||
|
|
||
| foreach ( $sitemap_urls as $sitemap_url ) { | ||
| $urls = $this->extract_sitemap_urls( $sitemap_url ); |
There was a problem hiding this comment.
- Can you please align the
=signs.
admin/class-nginx-helper-admin.php
Outdated
|
|
||
| $urls = array(); | ||
|
|
||
| if ( $xml === false ) { |
There was a problem hiding this comment.
- Please use Yoda conditions.
| @@ -40,6 +40,7 @@ | |||
| 'purge_page_on_deleted_comment', | |||
| 'purge_feeds', | |||
| 'smart_http_expire_form_nonce', | |||
| 'preload_cache', | |||
There was a problem hiding this comment.
- Please use tabs instead of spaces. Also, check this in other places.
Adds code refactoring for develop branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The aim of this PR is to sync the develop branch with master branch.
Testing
The code has been tested locally and is working as expected.
To Test the functionality -
developbranch.PR's included