just in case that both functions are valid. I found this when I try t… #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o add h264 support in our repo.
|
Hey Jeff - yep, can definitely see how that could be problematic. I'm wondering if instead of running them both (which might also cause confusion) we just throw an error if both are configured and then put the responsibility for determining which option to pass back onto the implementer. Alternately, if you think there is value in being able to chain sdpfilters, it might be better to handle things by reducing over an array. Thoughts? |
|
I'd suggest reducing over the array. Just my 2c worth. |
|
@nathanoehlman maybe you could update the PR with what you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I add h264 in our repo via sdpFilter, it never runs. Then I found it is overwritten by the sdpfilter.