Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global leaks #11

Closed
jonnor opened this issue Oct 21, 2014 · 2 comments
Closed

Global leaks #11

jonnor opened this issue Oct 21, 2014 · 2 comments

Comments

@jonnor
Copy link

jonnor commented Oct 21, 2014

Running a simple tests which creates two datachannels and sends between them shows:

Error: global leaks detected: Primus, RTCSessionDescription, RTCIceCandidate, isValid

ran using mocha.checkLeaks()
@DamonOehlman
Copy link
Member

Thanks @jonnor I'll have a look into it. isValid in particular looks pretty suspect.

DamonOehlman added a commit that referenced this issue Oct 21, 2014
@DamonOehlman
Added simple mocha test suite to replicate #11
b7fc0f9
DamonOehlman added a commit to rtc-io/rtc-attach that referenced this issue Oct 22, 2014
@DamonOehlman
Fix isValid global leak - see rtc-io/rtc#11
dd3b13a
@DamonOehlman
Copy link
Member

@jonnor This has been fixed in the 3.1.2 release. It might take a little while to propagate to the jsdelivr cdn though. Thanks again for reporting :)

Additionally, I'll wire up the zuul tests (using mocha) to use saucelabs in the next little while so we can get the heads up on these things in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonnor @DamonOehlman