Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tooltip on horizontal filter bar and sync #1

Merged
merged 35 commits into from
Oct 26, 2023
Merged

fix tooltip on horizontal filter bar and sync #1

merged 35 commits into from
Oct 26, 2023

Conversation

rtexelm
Copy link
Owner

@rtexelm rtexelm commented Oct 26, 2023

SUMMARY

Allow SQL field in the Edit Dataset Modal to display entire queries without number of lines displayed being limited to 21. The field should not have any restriction on line length.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:
SQL field
AFTER:
SQL Field unbridled

TESTING INSTRUCTIONS

  1. Find or create a dataset that is powered by a long query.
  2. Click on the Edit Dataset action.
  3. Expand the SQL field.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

justinpark and others added 30 commits October 17, 2023 15:33
@justinpark
fix: warning of nth-child (apache#23638)
16cc089
@john-bodley
chore: Cleanup hostNamesConfig.js (apache#25543)
32e37d8
@hughhhh
fix(tags): +n tags for listview (apache#25603)
a27a809
@dependabot
build(deps-dev): bump @types/jsonwebtoken from 9.0.3 to 9.0.4 in /sup…
8b32b2a 
…erset-websocket (apache#25688)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@michael-s-molina
chore: Adds 3.0.1 data to CHANGELOG.md (apache#25691)
dc06fb8
@OskarNS
fix(dremio): Fixes issue with Dremio SQL generation for Charts with S…
be82657 
…eries Limit (apache#25657)
@eschutho
chore: add latest-official docker tag (apache#25322)
26498fc
@mikelv92
feat: Add week time grain for Elasticsearch datasets (apache#25683)
e7cdfee 
Co-authored-by: Mikel Vuka <mikel.vuka@zalando.de>
@giftig
fix(sqllab): reinstate "Force trino client async execution" (apache#2…
4e94fc4 
…5680)
@dependabot
build(deps-dev): bump @types/node from 20.8.6 to 20.8.7 in /superset-…
1d37f3a 
…websocket (apache#25700)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@RahulK4102
docs(README): remove typo (apache#25710)
bac5a85
@dependabot
build(deps-dev): bump @types/uuid from 9.0.4 to 9.0.6 in /superset-we…
e29e268 
…bsocket (apache#25701)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
build(deps-dev): bump @types/cookie from 0.5.1 to 0.5.3 in /superset-…
07796b7 
…websocket (apache#25689)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@Khrol
fix: remove unnecessary redirect (apache#25679)
da42bf2
@CorbinBullard
feat: Funnel/tooltip-customization (apache#25666)
dfff3c1
@soniagtm
feat: add database and schema names to dataset option (apache#25569)
39ad322 
Co-authored-by: Sonia <sonia.gautam@agoda.com>
@sebastianliebscher
chore: Change the format for sha512 sum for releases (apache#25577)
505678b
@mdavidsen
chore: helm chart: bump appVersion to 3.0.1 (apache#25709)
def7cd1
@dmeaux
feat: add France's regions to country map visualization (apache#25676)
ee23690
@Always-prog
fix(chore): dashboard requests to database equal the number of slices…
75a7431 
… it has (apache#24709)
@dpgaspar
fix: bump to FAB 4.3.9 remove CSP exception (apache#25712)
8fb0c8d
@mikelv92
refactor: use DATE_TRUNC for Elasticsearch time grain (apache#25717)
9972ac6 
Co-authored-by: Mikel Vuka <mikel.vuka@zalando.de>
@rusackas
fix(driver): bumping DuckDB to 0.9.2 (apache#25718)
4ac8f82
@rtexelm
Alter filter control descrip tooltip style
6e67000
@betodealmeida
fix(metadb): handle durations (apache#25727)
ed87470
chore: updated base DAO find_by_id to return generic type (apache#25726)
4aef771
@dependabot
build(deps-dev): bump eslint from 8.51.0 to 8.52.0 in /superset-webso…
cbbf2be 
…cket (apache#25735)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@rtexelm
fix(horizontal filter label): show full tooltip with ellipsis (apache…
e4173d9 
…#25732)
@craig-rueda
chore(websocket): [WIP] Making JWT algos configurable (apache#25521)
861ee8b
@gnought
chore: bump pymssql version (apache#25737)
419d122
@rtexelm rtexelm closed this Oct 26, 2023
@rtexelm rtexelm reopened this Oct 26, 2023
@rtexelm rtexelm changed the title fix(edit dataset modal): display full sql query in the sql field fix tooltip on horizontal filter bar and sync Oct 26, 2023
@rtexelm rtexelm merged commit 636a0f1 into master Oct 26, 2023
@rtexelm rtexelm deleted the dev/filter/tooltip/75824 branch October 26, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.