Rewrite overflow and overflowWrap using phantom types approach #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtfeldman
requested changes
Apr 17, 2018
src/Css.elm
Outdated
| overflow auto | ||
|
|
||
| -} | ||
| overflow : Overflow -> Style |
There was a problem hiding this comment.
I'd actually prefer to inline the types rather than using type aliases for functions like these. (In fact, I wouldn't even define the type alias Overflow!)
The reason for this is that this way, if you give overflow a value it doesn't accept, the compiler error message will list all the values that are permitted. (e.g. visible, hidden, etc.)
Sorry this wasn't clear!
There was a problem hiding this comment.
I'm pretty sure that was clear when I read it, but just wasn't present in my mind when I was writing the code :-)
Thanks for the review! Should be fixed now.
| Value "hidden" | ||
|
|
||
|
|
||
| {-| The `visible` value used for properties such as [`visibility`](https://css-tricks.com/almanac/properties/v/visibility/), [`overflow`](https://css-tricks.com/almanac/properties/o/overflow/) and [`pointer-events`](https://developer.mozilla.org/en-US/docs/Web/CSS/pointer-events). |
There was a problem hiding this comment.
Love the detail on these docs! 😻
rtfeldman
approved these changes
Apr 17, 2018
|
Awesome, thanks @juanedi! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restored properties:
overflowoverflowXoverflowYoverflowWrap