Add float #416
Merged
Add float #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianvanburken
commented
Apr 30, 2018
|
|
||
| ## Float | ||
|
|
||
| @docs float |
There was a problem hiding this comment.
@rtfeldman do I need to add a line containing the values left_, right_, and none here? Since those are already defined in with other CSS properties
There was a problem hiding this comment.
Nah, I'd say leave them where they are! 👍
rtfeldman
approved these changes
May 1, 2018
|
|
||
| ## Float | ||
|
|
||
| @docs float |
There was a problem hiding this comment.
Nah, I'd say leave them where they are! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution Checklist
Valueis an open record with a single field. The field's name is the value's name, and its type isSupported. For examplefoo : Value { provides | foo : Supported }Styleaccepts a closed record ofSupportedfields, which always includesinherit,initial, andunsetbecause all CSS properties support those three values! For example,borderFoo : Value { foo : Supported, bar : Supported, inherit : Supported, initial : Supported, unset : Supported } -> Stylephantom-typesbranch, notmaster!