Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phantom types: fix wordbreak #419

Merged

Conversation

BrianHicks
Copy link
Collaborator

@BrianHicks BrianHicks commented May 1, 2018

wordBreak currently has the wrong signature in phantom-types 😢 This fixes it. I think it's right! But always good to have a second set of eyes on it 😄

Also adds a Travis check for type signatures so future issues on phantom-types should fail the build.

@brianvanburken
Copy link
Collaborator

As far as I can see word-break is not a value but a property so it shouldn't have provides. Source: https://developer.mozilla.org/en-US/docs/Web/CSS/word-break. I see that I did forget to add -> Style in #417. I apologize for the mistake! :(

@BrianHicks BrianHicks mentioned this pull request May 1, 2018
7 tasks
@BrianHicks
Copy link
Collaborator Author

  1. yep! I missed that in another branch too. Awhoops! Once the test suite works again it will catch these. Thanks for the catch. <3
  2. you're fine, these things happen. Just needed a little tweak, and I've added a check for that to CI. Thanks for writing it in the first place!

@rtfeldman
Copy link
Owner

Looks good, thanks @BrianHicks!

And yeah, totally don't sweat it @brianvanburken 😄 - thanks for the contribution!

@rtfeldman rtfeldman merged commit 5d4219f into rtfeldman:phantom-types May 1, 2018
@BrianHicks BrianHicks deleted the phantom-types--fix-wordbreak branch May 2, 2018 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants